Support JIT plugin version wildcards#1287
Conversation
|
Thanks for the contribution! Before we can merge this, we need @bailey-coding to sign the Salesforce Inc. Contributor License Agreement. |
|
I signed it |
|
@bailey-coding , I'll get this reviewed shortly, and we'll make sure you're credited. |
I don't mind too much about credit, but getting it reviewed, and if it makes sense approved and merged would be amazing. Thank you! 🙏 |
|
@bailey-coding , the PR looks solid, and I'm satisfied with my manual QA. Ideally, you could also add test coverage for the new fix, with something that used to fail and now passes thanks to the fix. Is that something you'd be able to do at this time? |
|
Yeah, for sure. I can add some tests tomorrow |
|
@bailey-coding , I'm still debugging the CLA status indicator, but I do know that if you create a new PR with the same changes after signing, then that second PR will show the CLA as having been signed. |
|
@bailey-coding , alternatively, you can just close and re-open the same PR and the CLA status should update. |
Closes #1286